fix: support QUIC listeners with multiple filter chains for different hostnames #7843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
fix-http3-with-multiple-hosts
branch
from
0ea9386 to
5d25751
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7843 +/- ##
==========================================
- Coverage 72.72% 72.71% -0.01%
==========================================
Files 235 235
Lines 35100 35100
==========================================
- Hits 25526 25524 -2
- Misses 7757 7759 +2
Partials 1817 1817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
force-pushed
the
fix-http3-with-multiple-hosts
branch
6 times, most recently
from
1d73f58 to
c4c6383
Compare
Signed-off-by: Huabing Zhao <[email protected]> add e2e test for HTTP3 with multiple hosts Signed-off-by: Huabing(Robin) Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-http3-with-multiple-hosts
branch
from
c4c6383 to
79535db
Compare
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
fix-http3-with-multiple-hosts
branch
from
a4cfe86 to
300fb2a
Compare
Signed-off-by: Huabing(Robin) Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-http3-with-multiple-hosts
branch
from
300fb2a to
3488b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds HTTP/3
filter chain matchersupport for QUIC listeners to honor multiple hostnames/certificates (SNI) like TCP/TLS listeners.TCL/TLS listeners are unchanged. They still use filterChainMatch and TLS inspector listener filter to match on SNI, so this won't break existing EnvoyPatchPolicies and Extension servers.Update: this PR still uses filter_chain_match.server_names for QUIC listener. Envoy’s QUIC stack parses SNI itself, so filter_chain_match.server_names works without TLS Inspector for QUIC listeners. TLS Inspector is only needed for TCP/TLS listeners.
Fixes: #5660