http: support per-backend StreamOptions in MuxDemux::multicast #42777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdauchy
force-pushed
the
mux
branch
3 times, most recently
from
c67756a to
23bf28c
Compare
botengyao
approved these changes
Dec 30, 2025
Member
|
/retest |
Previously, MuxDemux::multicast accepted a single StreamOptions for all backends, which meant per-backend timeouts couldn't be configured. The mcp_router worked around this by using the maximum timeout across all backends. This change adds an optional `options` field to MuxDemux::Callbacks, allowing callers to specify per-backend StreamOptions. When set, these options override the default options passed to multicast(). The mcp_router now uses this feature to set proper per-backend timeouts instead of the max-timeout workaround. Signed-off-by: William Dauchy <[email protected]>
botengyao
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Previously, MuxDemux::multicast accepted a single StreamOptions for all backends, which meant per-backend timeouts couldn't be configured. The mcp_router worked around this by using the maximum timeout across all backends.
This change adds an optional
optionsfield to MuxDemux::Callbacks, allowing callers to specify per-backend StreamOptions. When set, these options override the default options passed to multicast().The mcp_router now uses this feature to set proper per-backend timeouts instead of the max-timeout workaround.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]