Repository navigation
muskan/externalize-images-codex-generates - #3151
Open
MuskanPaliwal wants to merge 9 commits into
Open
MuskanPaliwal wants to merge 9 commits into
MuskanPaliwal wants to merge 9 commits into
Conversation
Codex stores a generated image as bare base64 in image_generation_call.result, which only the data URI match looked for. Entire-Checkpoint: 01M7863GM0MR3TF3B91AQZEAES
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The generated-image externalization change has no active review issues.
No open issues 🎉
What changed in this PR
Extends Entire CLI’s Codex transcript image externalization to include generated images stored as bare base64 in image_generation_call.result, alongside existing data-URI images.
Changes:
- Collects generated image payloads for externalization, with media types detected from image bytes.
- Adds unit coverage for byte-exact restoration and mixed pasted/generated images.
- Extends the full-hook integration test to verify generated image storage and reinjection.
| File | Description |
|---|---|
cmd/entire/cli/transcript/imageextract/imageextract.go |
Recognizes generated image results during Codex image collection. |
cmd/entire/cli/transcript/imageextract/codex_test.go |
Tests generated image extraction and round-trip restoration. |
cmd/entire/cli/integration_test/codex_image_externalize_test.go |
Verifies generated images are externalized and restored through the hook flow. |
Review effort: Balanced
…ages-codex-generates
An image Codex generates whose bytes match no known type is stored as a .bin asset and still round-trips byte-exactly. Entire-Checkpoint: 01M79XCJMXV1QBP5AJD5QQ3VAY
Generated images are bare base64 in image_generation_call.result, not data URIs; update the comments and the Codex row in the image table. Entire-Checkpoint: 01M79ZWX2D2X50QX65JTT9ZGDC
gtrrz-victor
marked this pull request as ready for review
November 13, 2026 10:58
…ages-codex-generates # Conflicts: # docs/security-and-privacy.md
Redaction skipped the whole item, so a secret in Codex's revised_prompt was stored as written. Entire-Checkpoint: 01M7AC6GMS915489D71QSXGYGD
Externalizing swaps every copy of a value, so a non-image result copied into user text skipped redaction. Entire-Checkpoint: 01M7AC6J0JH8S63SJXCZZ985B4
…f the walks Entire-Checkpoint: 01M7AJGA90KW14QKADXSX1QMF7
…ages-codex-generates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft pull request was opened by Entire to back a trail. Feel free to edit the title or body, but keep the hidden marker below: Entire uses it to close this pull request when the trail closes.