Skip to content

[Feature Request] Implement logoPunchoutBackground in SVG writer #455

Open

Description

@CodelineRed

logoPunchoutBackground(true) has no effect on SVG files.

Screenshot 2024-10-09 105946

<?php
use Endroid\QrCode\Builder\Builder;
use Endroid\QrCode\Encoding\Encoding;
use Endroid\QrCode\Writer\PngWriter;
use Endroid\QrCode\Writer\SvgWriter;

foreach (['png', 'svg'] as $extension) {
    $generalBuilder = Builder::create();

    if ($extension === 'png') {
        $generalBuilder->writer(new PngWriter());
    } else {
        $generalBuilder->writer(new SvgWriter());
    }

    $generalBuilder->writerOptions([])
        ->data('https://github.com/Bacon/BaconQrCode')
        ->encoding(new Encoding('UTF-8'))
        ->size(320)
        ->margin(10)
        ->logoPath('logo.png')
        ->logoResizeToWidth(100)
        ->logoPunchoutBackground(true);
    }

    $generalBuilder->build()->saveToFile('qrcode.' . $extension);
}

Tested with 5.1.0

Activity

  1. DharmenderRajput commented on Nov 14, 2024

    @DharmenderRajput

    Confirmed with v6.0.0

  2. changed the title [-]SVG and logoPunchoutBackground(true)[/-] [+][Feature Request] Implement logoPunchoutBackground in SVG writer[/+] on Nov 14, 2024
  3. self-assigned this
    on Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions