BUGFIX for EndroidQrCodeExtension::createBuilderDefinition#84
Open
Shoplifter wants to merge 1 commit intoendroid:mainfrom
Open
BUGFIX for EndroidQrCodeExtension::createBuilderDefinition#84Shoplifter wants to merge 1 commit intoendroid:mainfrom
Shoplifter wants to merge 1 commit intoendroid:mainfrom
Conversation
keys in array $builderConfig are snake_case not camelCase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LabelFontSize or labelFontPath are not taken from Configuration if both values are defined in config.
Reason: Keys in array $builderConfig are snake_case not camelCase.
If both values are defined in the configuration, the one defined first was overwritten by the default value.