Rename DataUpdateCurrentsPerPhase to DataUpdateCurrentPerPhase (BC)#183
Rename DataUpdateCurrentsPerPhase to DataUpdateCurrentPerPhase (BC)#183andig wants to merge 2 commits into
Conversation
|
@sthelen-enqs this is a breaking chore fix that would help improve naming consistency |
|
@andig Thanks for the contribution— you're right that CurrentPerPhase is the correct name and Currents is the outlier (the MPC interface method is already CurrentPerPhase). |
|
@uhl thank you for the comment. I agree this is a breaking change. However- with 0.x versions breaking changes are to be expected. The issue here is that it makes the library usage confusing and imho more than a cosmetic rename. PR (and commit) is already named |
|
After some more discussion, we've decided not to go ahead with this here. The rename is a relatively minor change and the name isn't so wrong that we think the break is worth it right now. |
Fix #182