NXT-570: Added background option for transparent Image - #405
Merged
Conversation
… and added Changed ImageItem to be able to use the new props.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #405 +/- ##
========================================
Coverage 82.66% 82.66%
========================================
Files 153 153
Lines 7620 7620
Branches 2318 2318
========================================
Hits 6299 6299
Misses 1027 1027
Partials 294 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # samples/sampler/stories/default/Image.js # samples/sampler/stories/default/ImageItem.js
daniel-stoian-lgp
left a comment
daniel-stoian-lgp
left a comment
Contributor
There was a problem hiding this comment.
check my comments
Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
daniel-stoian-lgp
approved these changes
Jul 30, 2026
daniel-stoian-lgp
requested changes
Jul 31, 2026
daniel-stoian-lgp
left a comment
daniel-stoian-lgp
left a comment
Contributor
There was a problem hiding this comment.
please add changelog. i will keep the PR blocked to avoid accidental merge of github actions file
daniel-stoian-lgp
approved these changes
Jul 31, 2026
dan-ichim-lgp
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added storybook controls for background change in Image and ImageItem.
Resolution
Additional Considerations
Links
NXT-570
Comments