Inertia and Damper are also condition-ed effects.#168
Closed
leosat wants to merge 1 commit intoemberian:mainfrom
Closed
Inertia and Damper are also condition-ed effects.#168leosat wants to merge 1 commit intoemberian:mainfrom
leosat wants to merge 1 commit intoemberian:mainfrom
Conversation
Author
|
P.S. @emberian , @coolreader18 I don't know if maintainers would wish all 4 condition-ed effects be textually grouped together. If yes, I can redo the patch. For now - I just modify "in-place" to propagate condition data. |
Author
|
Moved to #169 with a better patch: forgotten to update reverse conversion routine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Currently condition data is not propagated for those effects, however it needs to.
The four condition-ed effects are spring, friction, damper, inertia:
Some refs:
Universal Serial Bus (USB) Device Class Definition for Physical Interface Devices (PID)
https://www.usb.org/sites/default/files/documents/pid1_01.pdf
page 11, Table 3: Effect Types
https://learn.microsoft.com/en-us/gaming/gdk/docs/reference/input/gameinput-v2/structs/gameinputforcefeedbackparams-v2?view=gdk-2510
ffbtools also provide condition settings for those effects.
This patch adds condition data propagation to evdev API for the latter two effects.