Skip to content

Concatenate query list field once #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Aug 26, 2026
Merged

Concatenate query list field once #1325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions lib/plug/conn/query.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,19 +427,17 @@ defmodule Plug.Conn.Query do

# covers non-keyword lists
defp encode_pair(parent_field, list, encoder) when is_list(list) do
mapper = fn
field = parent_field <> "[]"

Enum.map_intersperse(list, ?&, fn
value when is_map(value) and map_size(value) != 1 ->
raise ArgumentError,
"cannot encode maps inside lists when the map has 0 or more than 1 element, " <>
"got: #{inspect(value)}"

value ->
[?&, encode_pair(parent_field <> "[]", value, encoder)]
end

list
|> Enum.flat_map(mapper)
|> prune()
encode_pair(field, value, encoder)
end)
end

# covers nil
Expand Down