Implement the greeter#2854
Conversation
|
This is pretty much ready. It took so long because I wanted to already prepare for an in session lock screen and I wasn't sure what the best way would be. So any opinions and suggestions regarding architecture are much appreciated. The animation for the deactivation of the greeter can probably be left to a follow up because without it the behavior is exactly the same as with the greeter compositor. I've been using this together with the osk branch for a while now on my starlite and it's working great with no need for any keyboard at all. |
42aabc8 to
b235ea4
Compare
b235ea4 to
b8c859b
Compare
| private enum SessionType { | ||
| DESKTOP, | ||
| GREETER, | ||
| INSTALLER; |
There was a problem hiding this comment.
Is the installer type necessary? I don't see it used anywhere, and is also rolled into greeter type when is_greeter is called.
There was a problem hiding this comment.
The greeter compositor launches different clients depending on whether it's a normal greeter session or a installer session (it doesn't launch the greeter, session manager, etc. in the installer session) that's why I added it here but I'm not familiar with the installer session and I haven't tested it 🤷
|
In regards to architecture for the lock screen, if I understand Gala and the goal correctly I would think the lock screen would almost be a view much like the multitasking view but with restrictions on events, such as keyboard shortcuts, that are accepted and hiding/disabling the dock, and maybe swapping out wingpanel for a more basic one. As for animations, I would imagine going into the lock screen would be performing the typical hide animation of windows, panel, and dock, followed by the background blurring, and then the lock screen widgets being shown. Going out of the lock screen would be the reverse. |
That's pretty much exactly how it's implemented here :)
That sounds really cool but I think it would be some more effort so ig I'd rather leave that to a follow up? Given that on main there's also no animation at all I think it would be better to keep this PR from getting too big. |
Ok cool, having the manager, unlike the multitasking view, made me unsure it was working a bit on its own instead of behaving like another view. Sweet!
Absolutely! I would expect a different PR as well, I figured I would toss in my thoughts since you had brought up animations in the description; don't know how it would be able to be done but maybe getting the gears turning would help somebody figure the how out. |
danirabbit
left a comment
There was a problem hiding this comment.
This looks good to me. I'd like to get this merged so we can unblock OS 9 dailies and we can further hash it out before release 🚀
92ebe74 to
3a6006a
Compare
|
A few notes:
But all in all it works and I think I'm happy with the architecture (though I'd always love to hear other ideas) so IMO it makes sense to merge and iterate :) |
|
I agree. Let's go! |
This allows running gala as the greeter compositor. It does that while preparing for having an in session lock screen.
It introduces:
This is already enough to run gala as the greeter compositor. The long term goal is that the lock screen layer with the lock screen and lock screen shell window groups will also be used as a lock screen without switching ttys. This allows for a bunch of things like e.g. smoother animations, lock screen notifications, media controls etc.
Any feedback is appreciated especially regarding architecture and how we should animate the activation/deactivation of the lock screen layer. This animation will in the future be used for the lock screen but right now it would also be used when logging in to animate out the lock screen (aka to transition from the blurred background in the greeter to the normal session).
Goes with elementary/greeter#878
Includes #2855