feat: auto-roll chromium deps SHA in build-images when files change #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automation to create PRs for updating the CHROMIUM_SRC_SHA in electron/build-images when the monitored Chromium files (build/install-build-deps.sh, build/install-build-deps.py) change between the current pinned SHA and Chromium HEAD. This runs both as a cron job and automatically when Chromium PRs are merged in electron/electron, but only creates PRs when there's an actual difference in the monitored files.
Add comprehensive tests for the didChromiumFilesChange function: - Returns false when no files changed between SHAs - Returns true when first/second/both files changed - Returns false when content only differs in whitespace - Handles empty file list and single file cases - Tests getChromiumHeadSha and getChromiumFileContent utilities
Simplify chromium-gitiles.ts by using Node.js native fetch API instead of manually implementing HTTP requests with the https module.
dsanders11
approved these changes
Dec 19, 2025
| d(`Found existing PR: #${pr.number} opened by ${pr.user.login}`); | ||
|
|
||
| // Check to see if automatic roll has been temporarily disabled | ||
| const hasPauseLabel = pr.labels.some((label) => label.name === 'roller/pause'); |
Member
There was a problem hiding this comment.
note: at some point we should really pull 'roller/pause' out into src/constants.ts since multiple files now have it duplicated.
| const { owner, repo } = REPOS.buildImages; | ||
|
|
||
| const diffLink = | ||
| `https://chromium.googlesource.com/chromium/src/+log/` + |
Member
There was a problem hiding this comment.
Suggested change
| `https://chromium.googlesource.com/chromium/src/+log/` + | |
| 'https://chromium.googlesource.com/chromium/src/+log/' + |
suggestion(non-blocking): this could be single quotes rather than backticks since there's no substitution in this part which is just being concatenated.
| ); | ||
|
|
||
| const match = content.match(CHROMIUM_SHA_REGEX); | ||
| if (!match || !match[1]) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!match || !match[1]) { | |
| if (!match?.[1]) { |
suggestion(non-blocking): modern syntax is nice
codebytere
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automation to create PRs for updating the CHROMIUM_SRC_SHA in electron/build-images when the monitored Chromium files (build/install-build-deps.sh, build/install-build-deps.py) change between the current pinned SHA and Chromium HEAD.
This runs both as a cron job and automatically when Chromium PRs are merged in electron/electron, but only creates PRs when there's an actual difference in the monitored files.