[azure] Add support for new Audit Log format#15841
[azure] Add support for new Audit Log format#15841devamanv wants to merge 3 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @devamanv |
| ignore_missing: true | ||
| - rename: | ||
| field: azure.auditlogs.properties.AdditionalDetails | ||
| target_field: azure.auditlogs.properties.additional_details_as_string |
There was a problem hiding this comment.
Should this field renamed to additional_details?
| ignore_missing: true | ||
| - rename: | ||
| field: azure.auditlogs.properties.Category | ||
| target_field: azure.auditlogs.properties.category_code |
There was a problem hiding this comment.
Can we adopt the same field naming pattern from Azure and convert it to snake_case?
azure.auditlogs.properties.category
| ignore_missing: true | ||
| - rename: | ||
| field: azure.auditlogs.properties.ActivityDate | ||
| target_field: azure.auditlogs.properties.activity_datetime |
There was a problem hiding this comment.
Should this be activity_date? The below field is already processing activity_datetime.
| field: azure.auditlogs.properties.Actor.ApplicationName | ||
| target_field: azure.auditlogs.properties.actor.application_name | ||
| ignore_missing: true | ||
| if: ctx.azure?.auditlogs?.properties?.Actor?.ApplicationName != null |
There was a problem hiding this comment.
Is there a reason to add null check for some rename processor and not for the other processors?
| type: keyword | ||
| description: Name of the modified property. | ||
| - name: new | ||
| type: text |
There was a problem hiding this comment.
Do you think that the value for this field will exceed the keyword limit?
same applies to old as well.
| "33EE33AB6B081AAE8D3393611F5BEF6FF19B60489" | ||
| ], | ||
| "targets": { | ||
| "0": { |
There was a problem hiding this comment.
The targets should emit list of modified_properties. Can you check why there is an additional value 0? Similarly for modified_properties as well.
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
|
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Proposed commit message
The PR adds support for new Audit Log format as seen here.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues