Skip to content

fix-trigger-hour-dropdown#1591

Open
ultrahighsuper wants to merge 2 commits into
eigent-ai:mainfrom
ultrahighsuper:fix/trigger-hour-dropdown
Open

fix-trigger-hour-dropdown#1591
ultrahighsuper wants to merge 2 commits into
eigent-ai:mainfrom
ultrahighsuper:fix/trigger-hour-dropdown

Conversation

@ultrahighsuper

@ultrahighsuper ultrahighsuper commented Apr 29, 2026

Copy link
Copy Markdown

Related Issue

Closes #1590

Description

Fixes a UI bug in the Edit Trigger schedule panel where the Hour/Minute dropdown closes before selection when the user interacts with the dropdown's right-side scrollbar/slider.

Root cause was the input blur handler always closing the dropdown after a timeout, even during valid dropdown interaction.

Change made in src/components/ui/input-select.tsx:

  • Added a dropdown interaction guard (interactingWithDropdownRef) set on onMouseDownCapture for the dropdown panel.
  • Prevented blur-close while that interaction flag is active.
  • Reset the interaction flag on global mouseup while dropdown is open.

This keeps the dropdown open during scrollbar interaction and still allows normal outside-click close behavior.

Testing Evidence (REQUIRED)

  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

2026-04-29_09h07_02.mp4

@ultrahighsuper

Copy link
Copy Markdown
Author

@4pmtong
Please check this PR.

@ultrahighsuper

Copy link
Copy Markdown
Author

@Wendong-Fan
please check this PR.
It has 2 weeks pending.

@Douglasymlai Douglasymlai added design bug Something isn't working frontend labels Jul 3, 2026
@Douglasymlai

Copy link
Copy Markdown
Contributor

Hi @ultrahighsuper , thanks for the contribution.

Could you pull the latest main and resolve conflicts? We shipped a release last week with a fairly significant refactor of this component, so the current diff no longer applies cleanly against the latest version.

Once that's updated, feel free to re-request review and tag me — happy to take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixes a UI bug in the Edit Trigger schedule panel where the Hour/Minute dropdown closes

3 participants