Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the EIC container Spack environment to use Acts v45.1.1, aligning the pinned Acts version with the upstream Spack package definition updates referenced in #166.
Changes:
- Add upstream
spack/spack-packagescherry-picks needed to introduce Acts v45.x versions and improved variant dependency handling. - Update
spack-environment/packages.yamlto requireacts@45.1.1(keeping the existing variant set).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spack-packages.sh |
Adds the upstream cherry-pick commits that introduce Acts v45.0.0 / v45.1.0 / v45.1.1 and variant dependency handling updates. |
spack-environment/packages.yaml |
Pins Acts from @44.4.0 to @45.1.1 under package requirements. |
187890b to
a3346be
Compare
a3346be to
34bbdf2
Compare
34bbdf2 to
cbe2f99
Compare
|
Physics benchmarks are unhappy: |
|
Yeah. Fixed in then Gen1/Gen3 geometry branch... Need to extract and apply cleanly. |
Actually, this is already fixed (eic/EICrecon#2466). It just doesn't retroactively appear in the latest released EICrecon that's used in the default workflow (and nightly succeeded). So this is effectively on hold until the next release. |
|
I see some minor discrepancies in track projections
Looks like it picks up additional projection points in fEMCal and LFHCAL.
That are in forward, as expected
But there is a bit of phi modulation to it?
The predicted time of 25 meters is a bit concerning, is that a loop in the propagation? |




Briefly, what does this PR introduce?
Needs:
This PR update
actsto v45.1.1. Follows #166 with correct branch name. Juggler gets a minor upgrade to make sure it can handle the updated interfaces in Acts v45.