Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds the "just" command runner tool to the Spack package preferences. "Just" is a command runner similar to make that can be used to define and execute common development tasks, following the pattern established by the LDMX experiment.
Changes:
- Added package preferences for "just" version 1.46.0 in
spack-environment/packages.yaml
|
I think, this has rust in build closure. @wdconinc, please remind me, are we averse to that? |
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
|
|
|||
| eval "$(just --completions bash)" | |||
There was a problem hiding this comment.
/etc/eic-env.sh is POSIX sh and sources every /etc/profile.d/*.sh. This script unconditionally evals Bash completion output, which can produce syntax errors or complete: not found when sourced under sh (and also adds overhead for non-interactive shells). Guard this so it only runs when in bash (and ideally only interactive) and when just is available on PATH (e.g., check BASH_VERSION/$- and command -v just).
| eval "$(just --completions bash)" | |
| if [ -n "${BASH_VERSION:-}" ]; then | |
| case $- in | |
| *i*) | |
| if command -v just >/dev/null 2>&1; then | |
| eval "$(just --completions bash)" | |
| fi | |
| ;; | |
| esac | |
| fi |
We already have |
It appears, there is some demand for a tool to run common tools. My proposal is to follow what LDMX experiment did and adopt just. We can add justfiles to the relevant repositories.