Skip to content

Comments

feat: add just#171

Open
veprbl wants to merge 3 commits intomasterfrom
pr/add_just
Open

feat: add just#171
veprbl wants to merge 3 commits intomasterfrom
pr/add_just

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 18, 2026

It appears, there is some demand for a tool to run common tools. My proposal is to follow what LDMX experiment did and adopt just. We can add justfiles to the relevant repositories.

Copilot AI review requested due to automatic review settings February 18, 2026 16:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the "just" command runner tool to the Spack package preferences. "Just" is a command runner similar to make that can be used to define and execute common development tasks, following the pattern established by the LDMX experiment.

Changes:

  • Added package preferences for "just" version 1.46.0 in spack-environment/packages.yaml

@veprbl
Copy link
Member Author

veprbl commented Feb 18, 2026

I think, this has rust in build closure. @wdconinc, please remind me, are we averse to that?

Copilot AI review requested due to automatic review settings February 18, 2026 16:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

@@ -0,0 +1,3 @@
#!/bin/bash

eval "$(just --completions bash)"
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/etc/eic-env.sh is POSIX sh and sources every /etc/profile.d/*.sh. This script unconditionally evals Bash completion output, which can produce syntax errors or complete: not found when sourced under sh (and also adds overhead for non-interactive shells). Guard this so it only runs when in bash (and ideally only interactive) and when just is available on PATH (e.g., check BASH_VERSION/$- and command -v just).

Suggested change
eval "$(just --completions bash)"
if [ -n "${BASH_VERSION:-}" ]; then
case $- in
*i*)
if command -v just >/dev/null 2>&1; then
eval "$(just --completions bash)"
fi
;;
esac
fi

Copilot uses AI. Check for mistakes.
@wdconinc
Copy link
Contributor

I think, this has rust in build closure. @wdconinc, please remind me, are we averse to that?

We already have cryptography in rust. I don't have anything against rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants