feat: add Sequelize to config's declaration and test it works with sequelize-typescript#83
Open
Jeff-Tian wants to merge 4 commits intoeggjs:masterfrom
Open
feat: add Sequelize to config's declaration and test it works with sequelize-typescript#83Jeff-Tian wants to merge 4 commits intoeggjs:masterfrom
Jeff-Tian wants to merge 4 commits intoeggjs:masterfrom
Conversation
…quelize-typescript
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 85.71% 84.37% -1.34%
==========================================
Files 4 4
Lines 63 64 +1
==========================================
Hits 54 54
- Misses 9 10 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
第一个提交测试通过，第二个提交没有本质改动，测试败在 npminstall 这一步。我在 fork 的 TravisCI 也重现了，清除 Cache 后，通过了。 |
Contributor
Author
|
@dead-horse @fengmk2 Any chance to get it approved and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
index.d.ts增加Sequelize字段以反映真实的设置，以及支持TypeScript里定制这个字段。README.md增加如何在TypeScript版 egg 项目里使用sequelize-typescript的说明。test目录下增加在TypeScript版 egg 项目里使用sequelize-typescript的测试用例。README.md增加如何在本地运行此项目的单元测试的说明。test.sh以方便本地单元测试。