修改启动文件app.js、agent.js，将app.beforeStart替换为新版的启动自定义#76
Open
MrSmallLiu wants to merge 1 commit intoeggjs:masterfrom
Open
修改启动文件app.js、agent.js，将app.beforeStart替换为新版的启动自定义#76MrSmallLiu wants to merge 1 commit intoeggjs:masterfrom
MrSmallLiu wants to merge 1 commit intoeggjs:masterfrom
Conversation
dead-horse
reviewed
Jul 19, 2019
| } | ||
|
|
||
| async didLoad() { | ||
| // 请将你的插件项目中 app.beforeStart 中的代码置于此处。 |
Member
There was a problem hiding this comment.
需要把 loader 改造成 async function，否则你这里的变更有问题
|
这个pr有啥进展吗？egg-sequelize的启动时间可以放到willReady不？给上层异步注入db配置留出口子。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change