refactor(common): consolidate catalog construction into submodules#1582
Merged
refactor(common): consolidate catalog construction into submodules#1582
Conversation
LNSD
force-pushed
the
lnsd/refactor-common-catalog-constructors
branch
10 times, most recently
from
df5875e to
267b6cd
Compare
LNSD
force-pushed
the
lnsd/refactor-common-catalog-constructors
branch
from
267b6cd to
598e583
Compare
JohnSwan1503
approved these changes
Jan 19, 2026
Reorganize catalog construction from `datasets-derived` into specialized submodules under `common::catalog` to eliminate code duplication across services and establish clear separation between logical and physical catalog operations.
- Create `catalog::logical::for_query` for Arrow Flight server catalog construction
- Create `catalog::logical::for_dump` for derived dataset dump operations
- Create `catalog::logical::for_admin_api` for schema validation endpoints
- Create `catalog::logical::for_manifest_validation` for manifest verification
- Create `catalog::physical::{for_query,for_dump}` for physical execution plans
Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-common-catalog-constructors
branch
from
598e583 to
18de94e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize catalog construction from
datasets-derivedinto specialized submodules undercommon::catalogto eliminate code duplication across services and establish clear separation between logical and physical catalog operations.catalog::logical::for_queryfor Arrow Flight server catalog constructioncatalog::logical::for_dumpfor derived dataset dump operationscatalog::logical::for_admin_apifor schema validation endpointscatalog::logical::for_manifest_validationfor manifest verificationcatalog::physical::{for_query,for_dump}for physical execution plans