Skip to content

fix bug in common/io.py when retrieving the fstep in ZarrIO - #2771

Open
iluise wants to merge 6 commits into
developfrom
iluise/fix-forecast-steps-stream-lookup
Open

fix bug in common/io.py when retrieving the fstep in ZarrIO #2771
iluise wants to merge 6 commits into
developfrom
iluise/fix-forecast-steps-stream-lookup

Conversation

@iluise

@iluise iluise commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

There is a bug in common/io.py when retrieving the fstep info from ZarrIO.
the code looks for the 0/ERA5_in/0 group even if this stream was used just in input.
Changed it to loop over the streams and actually open only the first available stream in output.

Issue Number

Closes #2770

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

FastEvaluation

  • I have updated the public documentation if necessary

@github-actions github-actions Bot added bug Something isn't working infra Issues related to infrastructure labels Aug 21, 2026
@clessig
clessig requested a review from grassesi August 21, 2026 10:20
@clessig

clessig commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

@grassesi : could you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infra Issues related to infrastructure

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Bug in common/io.py for runs with forcing

2 participants