adjust font size and add run_id to legends in FastEval - #2756
Open
iluise wants to merge 3 commits into
Open
Conversation
…t customization - Append run_id to legend labels as '<run_id> - <label>' in plot_metric_region and quantile plots (matching existing ratio/heat_map behavior) - Add '(target)' to map titles when tag is 'targets' - Add apply_font_settings() utility for font_size/font_type via global_plotting_options - Call apply_font_settings in all plotter classes: Plotter, LinePlots, QuantilePlots, ScoreCards, BarPlots - Pass font_size/font_type through all plotter_cfg dicts in plot_orchestration.py
…tration level - Move apply_font_settings from plotter.py to plot_utils.py (clean imports) - Call once in plot_orchestration.py instead of in every plotter __init__ - Remove redundant calls from Plotter, LinePlots, QuantilePlots, ScoreCards, BarPlots
github-actions
Bot
added
the
eval
TillHae
suggested changes
Aug 18, 2026
| "plot_subtimesteps": reader.get_inference_stream_attr(stream, "tokenize_spacetime", False) | ||
| "font_size": global_plotting_opts.get("font_size"), | ||
| "font_type": global_plotting_opts.get("font_type"), | ||
| | plot_settings.get("plot_subtimesteps", False), |
Contributor
There was a problem hiding this comment.
This is a part of l. 893 and in this form it should return a syntax error
Contributor
|
Can we include include the Or is this completely independent from the evaluation package? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
example:
Issue Number
Closes #2716
Closes #2607
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60FastEvaluation