Skip to content

change to latest main for new sphinx needs linkage#82

Open
RolandJentschETAS wants to merge 27 commits intomainfrom
improvement_independend_repositories_sphinx
Open

change to latest main for new sphinx needs linkage#82
RolandJentschETAS wants to merge 27 commits intomainfrom
improvement_independend_repositories_sphinx

Conversation

@RolandJentschETAS
Copy link
Copy Markdown
Contributor

Notes for Reviewer

Change to latest sphinx linking

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a6cf548c-11e0-41cb-b2a1-07dde2d4c08f
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.16 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 5.991s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@RolandJentschETAS RolandJentschETAS marked this pull request as ready for review April 17, 2026 08:52
Comment thread score/datarouter/docs/index.rst Outdated
Comment thread score/mw/log/docs/index.rst
Co-authored-by: Raghavendra Maddikery <raghav.maddikery@gmail.com>
Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
Comment thread score/mw/docs/index.rst Outdated
RolandJentschETAS and others added 2 commits April 21, 2026 14:28
Co-authored-by: Raghavendra Maddikery <raghav.maddikery@gmail.com>
Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

Comment thread .github/workflows/coverage_report.yml
Comment thread .github/workflows/build.yml Outdated
Comment thread docs/features/logging/architecture/index.rst Outdated
Comment thread MODULE.bazel Outdated
)

bazel_dep(name = "score_tooling", version = "1.2.0")
git_override(
Copy link
Copy Markdown
Contributor

@rmaddikery rmaddikery Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU we should no longer use git_override as per bzlmod guidelines. Any particular reason we still need it?

Copy link
Copy Markdown
Contributor Author

@RolandJentschETAS RolandJentschETAS Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Tooling have not provided a version for this. And the bazel rules in S-CORE says that is normal until the next version. I hope always the tooling and docs_as_code make versions in case of major bugfixes. Unfortunately that's not always the case.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked tooling if and when they provide a new release ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooling is in rework ... Not sure, when they will provide a new version.

RolandJentschETAS and others added 2 commits April 21, 2026 15:26
Co-authored-by: Raghavendra Maddikery <raghav.maddikery@gmail.com>
Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
rmaddikery
rmaddikery previously approved these changes Apr 21, 2026
Copy link
Copy Markdown
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmaddikery
Copy link
Copy Markdown
Contributor

Why are QNX8 Builds skipped on the PR?

rmaddikery
rmaddikery previously approved these changes Apr 22, 2026
@RolandJentschETAS
Copy link
Copy Markdown
Contributor Author

RolandJentschETAS commented Apr 23, 2026

Why are QNX8 Builds skipped on the PR?

No idea, but I have heard rumors that some QNX builds have to be manually approved and started. The background are some security risks for the pipelines (It is open source, therefore anyone can raise an PR and the PR could change the workflow in a way, that the QNX license which is used by the workflow is compromised or forwarded to the attacker). This approvement is only possible by committers, which rules out that.

@RolandJentschETAS
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolve conflicts in MODULE.bazel and MODULE.bazel.lock:
- Use released versions of score_tooling (1.1.2), score_process (1.5.4),
  score_platform (0.5.5) from main instead of git_overrides
- Use score_bazel_platforms 0.1.2 from main
- Update MODULE.bazel.lock to match resolved dependencies

Co-authored-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Apr 28, 2026

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit 62b6741.

The conflicts in MODULE.bazel were resolved by adopting the released versions from main (score_bazel_platforms 0.1.2, score_tooling 1.1.2, score_process 1.5.4, score_platform 0.5.5) and removing the git_override blocks that were temporary workarounds until these versions were released. The MODULE.bazel.lock was updated to match the resolved dependencies.

@Y-Vaishnavi Y-Vaishnavi mentioned this pull request Apr 28, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants