Feature/extraction skeleton service elements clean#368
Open
rudresh-systream wants to merge 8 commits intoeclipse-score:mainfrom
Open
Feature/extraction skeleton service elements clean#368rudresh-systream wants to merge 8 commits intoeclipse-score:mainfrom
rudresh-systream wants to merge 8 commits intoeclipse-score:mainfrom
Conversation
…nServiceElements - Moves events_, fields_, methods_ maps from SkeletonBase into new SkeletonServiceElements class - Eliminates duplicated UpdateSkeletonReference loops in move ctor and move assign - Adds UpdateAllServiceElementReferences() private method called by both move operations - Adds 8 unit tests covering registration, update, move semantics and back-reference fixup - No downstream API breakage: type aliases re-exported via SkeletonBase::SkeletonEvents etc.
…etonServiceElements - Moves events_, fields_, methods_ maps from SkeletonBase into new SkeletonServiceElements class - Eliminates duplicated UpdateSkeletonReference loops in move ctor and move assign - Adds UpdateAllServiceElementReferences() private method called by both move operations - Adds 8 unit tests covering registration, update, move semantics and back-reference fixup - No downstream API breakage: type aliases re-exported via SkeletonBase::SkeletonEvents etc.
…rvice-elements-clean
rudresh-systream
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.