mw:com: add missing coverage to get set feature#350
Draft
KrishaDeshkool wants to merge 9 commits intoeclipse-score:mainfrom
Draft
mw:com: add missing coverage to get set feature#350KrishaDeshkool wants to merge 9 commits intoeclipse-score:mainfrom
KrishaDeshkool wants to merge 9 commits intoeclipse-score:mainfrom
Conversation
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
10 times, most recently
from
707811c to
c03c71b
Compare
The new order allows us to set the bindings to nullptrs by default for test only constructors. This will be useful for fields which will require optionally inserting get / set bindings. We change all constructors so that they're all consistent.
- Use a single test constructor which creates the get / set methods according to the provided bindings. This allows us to remove the test-only constructor overloads for each template arg combination. - Always store the get / set method dispatches as unique_ptrs even if they're not enabled (when disabled, they'll simply be nullptrs). This allows us to have a single private constructor which always accepts unique_ptrs (which may be valid or nullptrs).
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
3 times, most recently
from
5cb53d7 to
a92032d
Compare
Replaces the EnableGet/EnableSet/EnableNotifier bool template parameters on ProxyField and SkeletonField with a variadic pack of tags (WithGetter, WithSetter) declared in field_tags.h. Presence of a tag enables the matching API. The notifier surface stays unconditional on both sides, since a field without a notifier cannot propagate value changes. Also updates friend/forward declarations in ProxyEvent, ProxyMethod, SkeletonEvent and SkeletonMethod, the Trait::Field aliases plus the traits example doc, and the skeleton_field_test.cpp call sites.
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
from
a92032d to
5356435
Compare
KrishaDeshkool
commented
Apr 27, 2026
KrishaDeshkool
commented
Apr 27, 2026
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
3 times, most recently
from
ee6f66e to
4f42d9e
Compare
The instance_id field was redundant with element_fq_id.instance_id_, both were always set to the same value. Remove the field, the construction argument, and two now unused includes.
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
from
4f42d9e to
6fbc01f
Compare
KrishaDeshkool
requested review from
LittleHuba,
castler,
crimson11 and
hoe-jo
as code owners
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
from
6fbc01f to
bbab9a9
Compare
KrishaDeshkool
force-pushed
the
find_and_add_missing_tests
branch
from
bbab9a9 to
1c0cf03
Compare
Contributor
Author
|
putting it back to review since this needs to be updated after notifier tag discussion with Manuel and Brendan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the changes from the
add_field_tagsPRthe rest are the tests for already merged code.