mw/com: Add method configuration support to SOME/IP#332
Open
sahithi-nukala wants to merge 1 commit intoeclipse-score:mainfrom
Open
mw/com: Add method configuration support to SOME/IP#332sahithi-nukala wants to merge 1 commit intoeclipse-score:mainfrom
sahithi-nukala wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
Contributor
sahithi-nukala
commented
Apr 21, 2026
sahithi-nukala
commented
- Extend the SOME/IP configuration to support method deployment alongside existing events and fields.
- This includes new SomeIpMethodInstanceDeployment class, SomeIpServiceTypeDeployment struct, new SOME/IP ID type aliases (event, field, method, service), updated BUILD targets, parser logic for method parsing, and documentation updates.
- All related tests have been updated to reflect the new functionality, including updating the stale TerminateOnParsingSomeIP test now that SOME/IP configuration parsing is fully implemented.
sahithi-nukala
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
sahithi-nukala
force-pushed
the
sah_someip_method_config_extension
branch
from
b0f8b04 to
fe936b2
Compare
Contributor
|
For SOME/IP we already have the config work started as part of the eclipse-score/inc_someip_gateway. Should we then sync this somehow? Use the same subschema, or something like that? |
NEOatNHNG
requested changes
Apr 24, 2026
Contributor
NEOatNHNG
left a comment
NEOatNHNG
left a comment
There was a problem hiding this comment.
At least the JSON schema should be also extended.
sahithi-nukala
force-pushed
the
sah_someip_method_config_extension
branch
4 times, most recently
from
8bbf955 to
6cd415f
Compare
- Extend the SOME/IP configuration to support method deployment alongside existing events and fields. - This includes new SomeIpMethodInstanceDeployment class, SomeIpServiceTypeDeployment struct, new SOME/IP ID type aliases (event, field, method, service), updated BUILD targets, parser logic for method parsing, and documentation updates. - All related tests have been updated to reflect the new functionality, including updating the stale TerminateOnParsingSomeIP test now that SOME/IP configuration parsing is fully implemented.
sahithi-nukala
force-pushed
the
sah_someip_method_config_extension
branch
from
6cd415f to
b9ed353
Compare
Contributor
Author
yes, using the same subschema makes sense. After this PR gets merged, we can take the changes on top of it. |
Contributor
Author
yes its done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.