[TEST] Pin bazel_cpp_toolchains#52 and wire score_cpp_policies features#308
Draft
RSingh1511 wants to merge 7 commits intoeclipse-score:mainfrom
Draft
[TEST] Pin bazel_cpp_toolchains#52 and wire score_cpp_policies features#308RSingh1511 wants to merge 7 commits intoeclipse-score:mainfrom
RSingh1511 wants to merge 7 commits intoeclipse-score:mainfrom
Conversation
RSingh1511
force-pushed
the
rs/test-gcc-pr52
branch
7 times, most recently
from
5cd8dc2 to
33b55e6
Compare
10 tasks
LittleHuba
reviewed
Apr 20, 2026
Comment on lines
+114
to
+116
| "@score_cpp_policies//sanitizers/features:asan_ubsan_lsan", | ||
| "@score_cpp_policies//sanitizers/features:tsan", | ||
| "@score_cpp_policies//sanitizers/features:debug_symbols", |
Contributor
There was a problem hiding this comment.
QCC is GCC under the hood. You use the wrong features.
Comment on lines
+127
to
+129
| "@score_cpp_policies//sanitizers/features:asan_ubsan_lsan", | ||
| "@score_cpp_policies//sanitizers/features:tsan", | ||
| "@score_cpp_policies//sanitizers/features:debug_symbols", |
Contributor
There was a problem hiding this comment.
QCC is GCC under the hood. You use the wrong features.
| "-latomic", | ||
| ]}, | ||
| llvm_version = "19.1.7", | ||
| stdlib = {"": "stdc++"}, |
Contributor
There was a problem hiding this comment.
This makes the toolchain non-hermetic.
This example should provide a sysroot for LLVM. I'm working on setting this up in communication. We can adopt this afterwards.
Comment on lines
+80
to
+84
| # ============================================================================== | ||
| # GCC-compatible sanitizer features | ||
| # ============================================================================== | ||
| # The @score_cpp_policies//sanitizers/features include -fsanitize-link-c++-runtime | ||
| # which is Clang-only. These define equivalent features without that flag. |
Contributor
There was a problem hiding this comment.
This stuff should end up in score_cpp_policies.
Comment on lines
16
to
25
| pkg_tar( | ||
| name = "suppressions_pkg", | ||
| srcs = [ | ||
| "//quality/sanitizer:repo_suppressions", | ||
| "@score_cpp_policies//sanitizers:suppressions", | ||
| ], | ||
| mode = "0444", | ||
| package_dir = "sanitizers/suppressions", | ||
| visibility = ["//visibility:public"], | ||
| ) |
Contributor
There was a problem hiding this comment.
This does not work. You add files with similar names into a single archive. This leads to overrides.
You must combine the files instead.
score_cpp_policies should provide a bazel rule for that.
Contributor
There was a problem hiding this comment.
We need the same for qcc to avoid issues like the ones I commented in MODULE.bazel.
RSingh1511
force-pushed
the
rs/test-gcc-pr52
branch
3 times, most recently
from
04ac261 to
9618ac0
Compare
RSingh1511
force-pushed
the
rs/test-gcc-pr52
branch
from
9618ac0 to
09d8bfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.