Conversation
d60e3a9 to
b670497
Compare
The new QNX package version 8.0.3 is added. Currently we do not support this version constraint on platform side so the constraint will still point 8.0.0.
b670497 to
56041d1
Compare
ltekieli
approved these changes
Apr 8, 2026
AlexanderLanin
previously approved these changes
Apr 8, 2026
ltekieli
requested changes
Apr 9, 2026
Member
ltekieli
left a comment
There was a problem hiding this comment.
Wrong sdp is downloaded still, following patch needs to be applied:
--- a/extensions/gcc.bzl
+++ b/extensions/gcc.bzl
@@ -215,10 +215,22 @@
"""
pkg_name = "{}_pkg".format(toolchain_info["name"])
+ # Resolve package identifier from original version fields, not the
+ # constraint-remapped tc_identifier. tc_identifier may differ from
+ # the actual version (e.g., sdp 8.0.3 is remapped to 8.0.0 for
+ # platform constraint compatibility), but the version matrix uses
+ # the real version.
+ if toolchain_info["sdk_version"] != "":
+ pkg_identifier = "sdk_{}".format(toolchain_info["sdk_version"])
+ elif toolchain_info["sdp_version"] != "":
+ pkg_identifier = "sdp_{}".format(toolchain_info["sdp_version"])
+ else:
+ pkg_identifier = toolchain_info["tc_identifier"]
+
matrix_key = "{cpu}-{os}{identifier}{runtime_es}".format(
cpu = toolchain_info["tc_cpu"],
os = toolchain_info["tc_os"],
- identifier = "-{}".format(toolchain_info["tc_identifier"]) if toolchain_info["tc_identifier"] != "" else "",
+ identifier = "-{}".format(pkg_identifier) if pkg_identifier != "" else "",
runtime_es = "-{}".format(toolchain_info["tc_runtime_ecosystem"]) if toolchain_info["tc_runtime_ecosystem"] != "" else "",
)
matrix = VERSION_MATRIX[matrix_key]
Use sdk_version/sdp_version instead of tc_identifier for the VERSION_MATRIX lookup, since tc_identifier may be remapped for platform constraint compatibility and differ from the real version.
ltekieli
approved these changes
Apr 9, 2026
AlexanderLanin
approved these changes
Apr 9, 2026
balajiyalam2
pushed a commit
to balajiyalam2/bazel_cpp_toolchains
that referenced
this pull request
Apr 14, 2026
* Add new QNX package into matrix The new QNX package version 8.0.3 is added. Currently we do not support this version constraint on platform side so the constraint will still point 8.0.0. * Resolve package identifier from original version fields Use sdk_version/sdp_version instead of tc_identifier for the VERSION_MATRIX lookup, since tc_identifier may be remapped for platform constraint compatibility and differ from the real version. --------- Co-authored-by: Lukasz Tekieli <lukasz.tekieli@bmw.de>
nradakovic
added a commit
that referenced
this pull request
Apr 15, 2026
* lock file refreshed * yml updated with lock error * Remove version from MODULE.bazel file (#48) The version of module will be patched during workflow checks on Bazel registru side. * Add new QNX package into matrix (#49) * Add new QNX package into matrix The new QNX package version 8.0.3 is added. Currently we do not support this version constraint on platform side so the constraint will still point 8.0.0. * Resolve package identifier from original version fields Use sdk_version/sdp_version instead of tc_identifier for the VERSION_MATRIX lookup, since tc_identifier may be remapped for platform constraint compatibility and differ from the real version. --------- Co-authored-by: Lukasz Tekieli <lukasz.tekieli@bmw.de> * Refactor README.md for clarity and conciseness (#37) Removed duplicate sections and clarified directory purposes. Signed-off-by: Nikola Radakovic <nikola.ra.radakovic@bmw.de> * lock file rebased to main * lock file updated * example/lock file updated --------- Signed-off-by: Nikola Radakovic <nikola.ra.radakovic@bmw.de> Co-authored-by: balajiyalam2 <Balaji.Yalam@qorix.ai> Co-authored-by: Nikola Radakovic <nikola.ra.radakovic@bmw.de> Co-authored-by: Lukasz Tekieli <lukasz.tekieli@bmw.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new QNX package version 8.0.3 is added. Currently we do not support this version constraint on platform side so the constraint will still point 8.0.0.