Skip to content

Remove needless TODOs #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
Jan 30, 2026
+5 −10
Merged

Remove needless TODOs #2447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79cb1d9
Remove needless TODOs
akurtakov Jan 30, 2026
52f12e3
Version bump(s) for 4.39 stream
eclipse-platform-bot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ant/org.eclipse.ant.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.ant.core; singleton:=true
Bundle-Version: 3.7.700.qualifier
Bundle-Version: 3.7.800.qualifier
Bundle-Activator: org.eclipse.ant.core.AntCorePlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
4 changes: 1 addition & 3 deletions ant/org.eclipse.ant.core/src/org/eclipse/ant/core/AntCorePreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -910,8 +910,6 @@ public IAntClasspathEntry getToolsJarEntry() {
/**
* Returns the <code>IAntClasspathEntry</code>s for the jars from ${user.home}/.ant/lib May return <code>null</code> if jars are found.
*
* TODO Should be promoted to API post 3.1
*
* @return the collection of <code>IAntClasspathEntry</code> found at ${user.home}/.ant/lib or <code>null</code> if none found of location does
* not exist
*/
Expand Down
4 changes: 1 addition & 3 deletions ant/org.eclipse.ant.core/src_ant/org/eclipse/ant/internal/core/ant/InternalAntRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2022 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -702,8 +702,6 @@ private void run(List<String> argList) {
printArguments(getCurrentProject());
}
if (IS_SECURITY_MANAGER_SUPPORTED) {
// TODO: call SecurityManagerUtil.isSecurityManagerAllowed() once it's more fine-grained,
// i.e. once https://github.com/apache/ant/pull/216 is available.
System.setSecurityManager(new AntSecurityManager(originalSM, Thread.currentThread()));
}
if (targets == null) {
Expand Down
2 changes: 1 addition & 1 deletion ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
Bundle-Localization: plugin
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.ant.launching;singleton:=true
Bundle-Version: 1.4.900.qualifier
Bundle-Version: 1.4.1000.qualifier
Bundle-Activator: org.eclipse.ant.internal.launching.AntLaunching
Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
org.eclipse.debug.core;bundle-version="[3.12.0,4.0.0)",
Expand Down
3 changes: 1 addition & 2 deletions ant/org.eclipse.ant.launching/src/org/eclipse/ant/internal/launching/AntLaunchingUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2016 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -142,7 +142,6 @@ private static String getTargetNamesForAntBuilder(ILaunchConfiguration configura
* if unable to access the associated attribute
*/
public static Map<String, String> getProperties(ILaunchConfiguration configuration) throws CoreException {
// TODO PLATFORM DEBUG 1.5 API
Map<String, String> map = configuration.getAttribute(IAntLaunchConstants.ATTR_ANT_PROPERTIES, (Map<String, String>) null);
return map;
}
Expand Down
Loading