Add filter to allow disabling an OSGi capability requirement - #1073
Merged
Conversation
merks
approved these changes
May 18, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
Seems like a good idea. Some tiny little suggestions.
laeubi
force-pushed
the
disbale_req
branch
2 times, most recently
from
June 10, 2026 06:11
4a0085d to
727af86
Compare
merks
approved these changes
Jun 10, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
Looks fine in general.
It would be nice if somewhere in all this is show an example of what's generated in the serialized p2 metadata for this.
Member
Author
|
I need to check why this breaks the build but have in the meanwhile prepared a symmetric change on the Tycho side as well: |
Co-authored-by: Ed Merks <Ed.Merks@gmail.com>
Member
Author
|
Build is now green, I'm not sure if we should merge this right now or wait for the next release before M2. @merks (or others) WDYT? |
Contributor
|
I think it's find to merge this for this cycle. We've done similar types of changes in the past without a single complaint as a result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to use generic require capability in builds that otherwise would create a cyclic dependency issue.
This is similar to what SWT does here:
https://github.com/eclipse-platform/eclipse.platform.swt/blob/7f9089ed7daaf630970fea7fa5bdb18cfba5cdcb/bundles/org.eclipse.swt/META-INF/p2.inf
!(org.eclipse.swt.buildtime=true)filter property that we then set here https://github.com/eclipse-platform/eclipse.platform.swt/blob/7f9089ed7daaf630970fea7fa5bdb18cfba5cdcb/bundles/org.eclipse.swt/pom.xml#L39-L41 to disable this only for building the host.This change has to actually happen at Tycho (where we should have a integration test), but for consistency and to gather some agreement first I opened it here.