chore(orch): log the process state

[jakubno]

Log the process state even if in another state than D

[cursor]

PR Summary

Low Risk
Low risk: this is primarily a logging/observability change in the Firecracker shutdown path, with termination behavior unchanged aside from an added gopsutil status lookup.

Overview
Improves Firecracker shutdown observability by removing the ps-based process state check and instead fetching the process Status() via gopsutil immediately before issuing a forced SIGKILL, logging the returned status codes when the kill is sent.

^{Reviewed by Cursor Bugbot for commit 67e5509. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6dc71b4644

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[arkamar]

I would guess that getProcessState() will most commonly return error because process was killed and reaped and it no longer exists (kill syscall returns when signal was delivered). Therefore I would expect state equal to "" in most cases. I would suggest to change it to something like this:

state, err := getProcessState(ctx, p.cmd.Process.Pid)
if err != nil {
   // undecided what exactly to do here, because `err` is mostly a good sign here original `Warn()` is a bit misleading.
} else {
   logger.L().Info(ctx, "sent SIGKILL to fc process", logger.WithSandboxID(p.files.SandboxID), zap.String("state", state))
}

[arkamar]

I don't like getProcessState() function. Calling extra process for one letter from /proc/<pid>/stat file is overkill. gopsutils has StatusWithContext() but it maps Linux letters to strings https://github.com/shirou/gopsutil/blob/c2a1624b9f3ed0b38ad67134b93397142ed67a23/process/process.go#L609