Skip to content

chore(clickhouse): limit number of concurrent connections for backup#2369

Merged
jakubno merged 1 commit intomainfrom
chore/limit-number-of-concurrent-connections
Apr 13, 2026
Merged

chore(clickhouse): limit number of concurrent connections for backup#2369
jakubno merged 1 commit intomainfrom
chore/limit-number-of-concurrent-connections

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Apr 13, 2026

No description provided.

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 13, 2026

PR Summary

Medium Risk
Limits ClickHouse backup concurrency, which could reduce load but may also slow backups or cause unexpected behavior if altinity/clickhouse-backup interprets the env var differently than expected.

Overview
Sets CLICKHOUSE_MAX_CONNECTIONS=2 for the clickhouse-backup batch job, capping concurrent connections used during create_remote backups to reduce pressure on the ClickHouse server while the periodic backup runs.

Reviewed by Cursor Bugbot for commit 6c47e15. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward config change adding a connection limit for the ClickHouse backup job.

Extended reasoning...

Overview

Adds a single environment variable CLICKHOUSE_MAX_CONNECTIONS=2 to the clickhouse-backup batch job's Nomad HCL config. The rest of the diff is whitespace alignment.

Security Risks

None. This is a tuning parameter for an internal backup job; no auth, crypto, or permissions code is touched.

Level of Scrutiny

Low. This is a one-line operational config change to a batch job that runs periodically. The variable is a well-known setting for altinity/clickhouse-backup to cap concurrent ClickHouse connections, reducing server pressure during backups.

Other Factors

No bugs were reported by the bug hunting system. The change is consistent with the existing pattern of env-var configuration in this file and has a clear operational motivation.

@jakubno jakubno merged commit a820899 into main Apr 13, 2026
86 of 87 checks passed
@jakubno jakubno deleted the chore/limit-number-of-concurrent-connections branch April 13, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants