Skip to content

chore(security): add 7-day cooldown for supply chain protection#1567

Open
saitota wants to merge 2 commits intodyoshikawa:mainfrom
saitota:chore/supply-chain-cooldown
Open

chore(security): add 7-day cooldown for supply chain protection#1567
saitota wants to merge 2 commits intodyoshikawa:mainfrom
saitota:chore/supply-chain-cooldown

Conversation

@saitota
Copy link
Copy Markdown
Contributor

@saitota saitota commented Apr 25, 2026

Summary

Adds 7-day cooldown to mitigate supply chain attacks (Trivy/LiteLLM/axios in March 2026).

  • pnpm-workspace.yaml: minimumReleaseAge: 10080 (7 days, in minutes)
  • .github/dependabot.yml: cooldown.default-days 1 → 7 (npm + github-actions)

Refs

saitota added 2 commits April 25, 2026 22:30
- pnpm-workspace.yaml: minimumReleaseAge=10080 (7 days)
- dependabot.yml: cooldown.default-days 1 -> 7
@cm-dyoshikawa
Copy link
Copy Markdown
Collaborator

@saitota

Thanks for putting this together. The CI action bumps look good to me, please go ahead with those.

On the cooldown side though, I think 7 days is too long for this project. The main concern is that it also delays security fixes by the same amount — if a CVE drops on a transitive dep, we'd be sitting on the patched version for a week before pnpm even considers it. pnpm's own docs note that "in most cases malicious releases are removed from the registry within an hour," and their example config uses 1 day (1440 minutes), so 7 days is well above what the upstream guidance suggests.

Also worth remembering that minimumReleaseAge is a floor, not a ceiling — any downstream user who wants a longer window can extend it on their side without us baking it into the project default.

I'd like to drop this to 1 day (1440) at least for now. Same change to cooldown.default-days in dependabot.yml — 1 day there feels right too. Happy to revisit if we see a concrete incident that a longer window would have caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants