fix: directory-aware root detection in CopilotRule.fromFile#1564
Merged
dyoshikawa merged 1 commit intomainfrom Apr 27, 2026
Merged
fix: directory-aware root detection in CopilotRule.fromFile#1564dyoshikawa merged 1 commit intomainfrom
dyoshikawa merged 1 commit intomainfrom
Conversation
Owner
Author
|
@dyoshikawa Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
CopilotRule.fromFile()detect root vs non-root usingrelativeDirPath + relativeFilePathwhenrelativeDirPathis provided, and fall back to filename-only detection for backward compatibility when it's not.resolvedRelativeDirPathfor reading non-root files so the directory context is preserved during file I/O and instance creation.CopilotRule.forDeletion()root detection to the same directory-aware logic.copilot-instructions.mdin a non-root directory is treated as non-root, and that root is detected only when both directory and filename match.Testing
pnpm vitest run src/features/rules/copilot-rule.test.tsand the test file passed (62/62 tests passed).pnpm cicheck, which completed successfully (format/lint/typecheck passed and the full test suite passed: 5262 tests).Codex Task