fix: drop root frontmatter when building CopilotRule#1563
Open
dyoshikawa wants to merge 1 commit intomainfrom
Open
fix: drop root frontmatter when building CopilotRule#1563dyoshikawa wants to merge 1 commit intomainfrom
dyoshikawa wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
copilotFrontmatterfor root rules inCopilotRule.fromRulesyncRule()and explicitly passfrontmatter: {}for root conversions.copilotFrontmatterfor non-root files.src/features/rules/copilot-rule.test.tsto assert root conversions return an empty frontmatter and no longer preservedescription,globs, orcopilot.excludeAgentvia the root conversion path.Testing
pnpm vitest run src/features/rules/copilot-rule.test.tsand it passed (60/60 tests).pnpm cicheck, which includes formatting, linting, typecheck and the full test suite, and all automated checks passed (5260tests passed, no failures).Codex Task