Skip to content

Conversation

@Olexandr88
Copy link
Contributor

Adds a model-level schema description for gas_solana_compute_limit and removes an outdated TODO comment. No logic changes.

@cursor
Copy link

cursor bot commented Dec 28, 2025

PR Summary

Adds concise schema metadata for Solana gas model.

  • Adds model-level description for gas_solana_compute_limit in dbt_subprojects/solana/models/_sector/gas/_schema.yml
  • Removes outdated TODO comments and a generic description line from the gas schema
  • No logic or model structure changes

Written by Cursor Bugbot for commit 7e94b8b. Configure here.

@github-actions github-actions bot marked this pull request as draft December 28, 2025 12:08
@github-actions github-actions bot added WIP work in progress dbt: solana covers the Solana dbt subproject labels Dec 28, 2025
@Olexandr88 Olexandr88 marked this pull request as ready for review December 28, 2025 12:10
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 28, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

description: >
Contains per-transaction compute unit limits for Solana transactions,
derived from on-chain transaction metadata.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML indentation causes properties to be parsed as description

The description: block scalar with > at 2-space indent has content at 4-space indent. Since meta:, config:, and columns: are also at 4-space indent, they will likely be parsed as part of the description text rather than as separate model properties. For a list item at 0-space indent, sibling properties like meta: need to be at 2-space indent (same as description:), not 4-space. This will cause the model metadata, configuration, and column tests to not be applied to the model.

Fix in Cursor Fix in Web

config:
tags: ['solana', 'gas', 'fees']
description: >
Gas Fees on Solana, including compute unit prices and prioritization fees
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema column tests don't match model's actual columns

The schema column tests (for blockchain, block_month, tx_hash, signer, tx_fee_raw, tx_fee_usd, etc.) were originally defined for gas_solana_fees but are now applied to gas_solana_compute_limit. The actual gas_solana_compute_limit.sql model only produces columns: tx_id, block_date, block_hour, block_time, block_slot, tx_index, and compute_limit. The schema tests will fail because these columns don't exist in the model.

Fix in Cursor Fix in Web

- name: gas_solana_tx_fees #todo: add full metadata and tests
- name: gas_solana_vote_fees #todo: add full metadata and tests
- name: gas_solana_fees #todo: add tests
- name: gas_solana_compute_limit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active model gas_solana_fees lost its schema tests

The schema definition for gas_solana_fees was removed along with the other model names. Unlike the other removed models (which only had names with TODO comments), gas_solana_fees is an active production model that feeds into gas.fees cross-chain view. It previously had metadata and column tests (not_null on tx_fee_raw, tx_fee, tx_fee_usd, unique on tx_hash, etc.) that correctly matched its columns. These tests will no longer run, reducing test coverage for a critical model.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: solana covers the Solana dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant