-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add schema metadata for gas_solana_compute_limit model #9159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR SummaryAdds concise schema metadata for Solana gas model.
Written by Cursor Bugbot for commit 7e94b8b. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
| description: > | ||
| Contains per-transaction compute unit limits for Solana transactions, | ||
| derived from on-chain transaction metadata. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML indentation causes properties to be parsed as description
The description: block scalar with > at 2-space indent has content at 4-space indent. Since meta:, config:, and columns: are also at 4-space indent, they will likely be parsed as part of the description text rather than as separate model properties. For a list item at 0-space indent, sibling properties like meta: need to be at 2-space indent (same as description:), not 4-space. This will cause the model metadata, configuration, and column tests to not be applied to the model.
| config: | ||
| tags: ['solana', 'gas', 'fees'] | ||
| description: > | ||
| Gas Fees on Solana, including compute unit prices and prioritization fees |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema column tests don't match model's actual columns
The schema column tests (for blockchain, block_month, tx_hash, signer, tx_fee_raw, tx_fee_usd, etc.) were originally defined for gas_solana_fees but are now applied to gas_solana_compute_limit. The actual gas_solana_compute_limit.sql model only produces columns: tx_id, block_date, block_hour, block_time, block_slot, tx_index, and compute_limit. The schema tests will fail because these columns don't exist in the model.
| - name: gas_solana_tx_fees #todo: add full metadata and tests | ||
| - name: gas_solana_vote_fees #todo: add full metadata and tests | ||
| - name: gas_solana_fees #todo: add tests | ||
| - name: gas_solana_compute_limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active model gas_solana_fees lost its schema tests
The schema definition for gas_solana_fees was removed along with the other model names. Unlike the other removed models (which only had names with TODO comments), gas_solana_fees is an active production model that feeds into gas.fees cross-chain view. It previously had metadata and column tests (not_null on tx_fee_raw, tx_fee, tx_fee_usd, unique on tx_hash, etc.) that correctly matched its columns. These tests will no longer run, reducing test coverage for a critical model.
Adds a model-level schema description for gas_solana_compute_limit and removes an outdated TODO comment. No logic changes.