fix(fetchMenu): fallback to $fetch on client after hydration#461
Open
StirStudios wants to merge 2 commits intodrunomics:2.xfrom
Open
fix(fetchMenu): fallback to $fetch on client after hydration#461StirStudios wants to merge 2 commits intodrunomics:2.xfrom
StirStudios wants to merge 2 commits intodrunomics:2.xfrom
Conversation
Contributor
|
sry for letting this lie so long. @StirStudios Could you clarify why this is needed? usually the menu-fetching should work just fine client-side as well + hydrate properly also? |
Contributor
Author
|
This fails for us on a full page refresh when used in the admin menu — specifically within the user account menu. Without this in place, the user menu breaks on full page refreshes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Scope
Validation