Run CI on pull requests against any base branch - #940
Open
drn wants to merge 1 commit into
Open
Conversation
The pull_request trigger was scoped to branches: [master], so CI never ran for PRs opened against a feature branch (e.g. stacked-PR workflows where a task branches off another task's branch). Drop the branch filter so pull_request fires regardless of base branch; push stays scoped to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branches: [master]filter on thepull_requesttrigger in.github/workflows/ci.ymlso CI runs for a PR regardless of its base branch — previously a PR opened against a feature branch (e.g. a stacked-PR workflow where a task branches off another task's branch) never triggered CI at all.pushstays scoped tomaster.Test plan