Skip to content

Fix NullReferenceException for mistyped default values on non-string columns in migrations #38399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −0
Open

Fix NullReferenceException for mistyped default values on non-string columns in migrations #38399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d9bfc6
Initial plan
Copilot Jun 10, 2026
8231f2b
Fix NRE for mistyped string default value on non-string column; add test
Copilot Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/EFCore/Storage/TypeMappingSourceBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ protected virtual bool TryFindJsonCollectionMapping(
out JsonValueReaderWriter? collectionReaderWriter)
{
if ((providerClrType == null || providerClrType == typeof(string))
&& modelClrType != typeof(string)
&& modelClrType.TryGetElementType(typeof(IEnumerable<>)) is { } elementType
&& elementType != modelClrType
&& !modelClrType.GetGenericTypeImplementations(typeof(IDictionary<,>)).Any())
Expand Down
20 changes: 20 additions & 0 deletions test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,26 @@ public void CreateIndexOperation_unique_datacompression(DataCompressionType data
""");
}

[Fact]
public virtual void AddColumnOperation_mistyped_default_legacy()
{
Generate(
new AddColumnOperation
{
Table = "People",
Name = "Id",
ClrType = typeof(int),
ColumnType = "int",
DefaultValue = "",
IsNullable = false
});

AssertSql(
"""
ALTER TABLE [People] ADD [Id] int NOT NULL DEFAULT N'';
""");
}

[Fact]
public virtual void AddColumnOperation_identity_legacy()
{
Expand Down
Loading