Skip to content

Code-fence C# conversion keywords in numeric conversions doc#54760

Merged
BillWagner merged 3 commits into
mainfrom
copilot/071fccf4-f7d2-23dc-fba0-c2c54efac225-keywords-over
Jul 15, 2026
Merged

Code-fence C# conversion keywords in numeric conversions doc#54760
BillWagner merged 3 commits into
mainfrom
copilot/071fccf4-f7d2-23dc-fba0-c2c54efac225-keywords-over

Conversation

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Japanese localization surfaced overlocalized C# keywords in the numeric conversions article. This PR updates the page so language keywords remain non-localizable inline code.

  • Scope

    • Updated docs/csharp/language-reference/builtin-types/numeric-conversions.md only.
  • Keyword localization hardening

    • Code-fenced prose occurrences of C# keywords in the intro sentence:
      • implicit
      • explicit (including “explicit conversion” phrasing)
  • Representative diff

    - An implicit or explicit conversion exists between any two numeric types. ... perform an explicit conversion.
    + An `implicit` or `explicit` conversion exists between any two numeric types. ... perform an `explicit` conversion.

Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/builtin-types/numeric-conversions.md docs/csharp/language-reference/builtin-types/numeric-conversions

Copilot AI requested review from Copilot and removed request for Copilot July 14, 2026 13:32
Copilot AI linked an issue Jul 14, 2026 that may be closed by this pull request
Copilot AI requested review from Copilot and removed request for Copilot July 14, 2026 13:34
Copilot AI changed the title [WIP] Fix keywords overlocalized by adding code fencing Code-fence C# conversion keywords in numeric conversions doc Jul 14, 2026
Copilot AI requested a review from BillWagner July 14, 2026 13:35

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one missed the mark. Please address my comments.

Comment thread docs/csharp/language-reference/builtin-types/numeric-conversions.md Outdated
Comment thread docs/csharp/language-reference/builtin-types/numeric-conversions.md Outdated
Copilot AI requested review from BillWagner and Copilot and removed request for Copilot July 14, 2026 18:12

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now ready for final review.

@BillWagner BillWagner marked this pull request as ready for review July 14, 2026 18:54
@BillWagner BillWagner requested a review from a team as a code owner July 14, 2026 18:54
Copilot AI review requested due to automatic review settings July 14, 2026 18:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce localization issues in the C# numeric conversions documentation by marking C# language keywords/type keywords as non-localizable inline code.

Changes:

  • Updated the implicit numeric conversions table so the From column’s C# type keywords are rendered as inline code within links (for example, int).
  • (Per PR description) Intended to code-fence prose occurrences of the implicit and explicit keywords in the introduction, but that change isn’t currently present in the file.

Comment thread docs/csharp/language-reference/builtin-types/numeric-conversions.md
@BillWagner BillWagner merged commit 2eb9f35 into main Jul 15, 2026
12 checks passed
@BillWagner BillWagner deleted the copilot/071fccf4-f7d2-23dc-fba0-c2c54efac225-keywords-over branch July 15, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keywords overlocalized

4 participants