Skip to content

Allow API diff area owner mentions - #10494

Merged
svick merged 3 commits into
dotnet:mainfrom
svick:add-api-diff-mention-allowlist
Jul 31, 2026
Merged

Allow API diff area owner mentions#10494
svick merged 3 commits into
dotnet:mainfrom
svick:add-api-diff-mention-allowlist

Conversation

@svick

@svick svick commented Jul 24, 2026

Copy link
Copy Markdown
Member

I believe the mentions in API diff PRs were not supposed to be escaped using `. This happened, because safe-outputs.mentions was not set. This PR adds all current area owners to the allowed list.

Summary

  • allow all lead and owner handles from dotnet/runtime docs/area-owners.md
  • allow the four static ASP.NET, WinForms, and WPF reviewer teams
  • regenerate the compiled agentic workflow

This prevents API diff review-checklist mentions from being escaped with backticks.

svick and others added 2 commits July 24, 2026 14:11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@svick
svick marked this pull request as ready for review July 24, 2026 12:29
@svick
svick requested a review from jeffhandley July 24, 2026 12:29
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@jeffhandley jeffhandley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and change, @svick!

I revised the list of mentionees by capturing every team and individual the workflow found it could possibly mention for how it finds them, and then verified all the names against the microsoft-team.md documentation we have in this repo.

Then I refactored the safe-output out into a shared import file so that we can reuse the list across workflows if needed and have a single place to maintain the list.

@svick
svick merged commit 0e10116 into dotnet:main Jul 31, 2026
3 checks passed
@svick
svick deleted the add-api-diff-mention-allowlist branch July 31, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants