Fix API Version with Status Using URL Segment Method - #1199
Open
commonsensesoftware wants to merge 1 commit into
Open
Fix API Version with Status Using URL Segment Method#1199commonsensesoftware wants to merge 1 commit into
commonsensesoftware wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix API Version with Status Using URL Segment Method
Description
Fix extracting API version with status using URL segment method. This is a limitation of how constraints are matched and parsed in route templates. This will add ever-so-slightly more overhead to matching API versions on incoming requests when versioning by URL segment, which was already the slowest method.
A nice side effect is that this same fallback mechanism works for matching incoming API versions for gRPC endpoints that version by URL segment because gRPC endpoints have their own route templates that do not map to constraints. This would make it near impossible to match such endpoints. gRPC endpoints can also version by query string, which does not have this issue nor any of the performance impact.