Skip to content

Remove invalid P/Invoke methods#1508

Merged
alinpahontu2912 merged 5 commits intodotnet:mainfrom
ds5678:remove-invalid-pinvoke-methods
Feb 11, 2026
Merged

Remove invalid P/Invoke methods#1508
alinpahontu2912 merged 5 commits intodotnet:mainfrom
ds5678:remove-invalid-pinvoke-methods

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Nov 20, 2025

These 3 methods have incorrect signatures for their entrypoint. Each of them has an overload with the correct signature.

Edit: I also went through and found a bunch of P/Invoke methods that have no corresponding native export.

@ds5678 ds5678 force-pushed the remove-invalid-pinvoke-methods branch from 86c2dca to 489e9e7 Compare December 20, 2025 20:03
@alinpahontu2912 alinpahontu2912 force-pushed the remove-invalid-pinvoke-methods branch from 489e9e7 to 7c2ebdf Compare February 9, 2026 15:06
@ds5678
Copy link
Contributor Author

ds5678 commented Feb 9, 2026

@alinpahontu2912 Can you rerun the CI? I think the failure was a random fluke.

Edit: I pushed a commit to make it run.

@alinpahontu2912 alinpahontu2912 force-pushed the remove-invalid-pinvoke-methods branch from 6965ef9 to b04bab5 Compare February 10, 2026 19:40
@alinpahontu2912 alinpahontu2912 self-requested a review February 11, 2026 09:28
Copy link
Member

@alinpahontu2912 alinpahontu2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alinpahontu2912 alinpahontu2912 force-pushed the remove-invalid-pinvoke-methods branch from b04bab5 to cd8c07e Compare February 11, 2026 09:32
@alinpahontu2912 alinpahontu2912 merged commit 57764e9 into dotnet:main Feb 11, 2026
2 checks passed
@ds5678 ds5678 deleted the remove-invalid-pinvoke-methods branch February 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants