Skip to content

Prevent scanning/signing of unrelated packages#4007

Open
samsharma2700 wants to merge 2 commits intomainfrom
dev/samsharma2700/fix_signing_packages_2
Open

Prevent scanning/signing of unrelated packages#4007
samsharma2700 wants to merge 2 commits intomainfrom
dev/samsharma2700/fix_signing_packages_2

Conversation

@samsharma2700
Copy link
Contributor

Description

(Part 2 of 2) Continuation of the package isolation work from Part 1. The CI/PR validation pipelines (ci-build-nugets-job.yml) have the same issue: they download dependency packages from previous stages into a directory, then build new NuGet packages into the same directory. The packagePath variable controls where built packages are published as pipeline artifacts, so any downloaded packages in the same location get re-uploaded as artifacts unnecessarily.

Solution

Apply the same packages/ vs output/ separation to the CI/PR pipelines:

  • packagePath (in ci-build-variables.yml) now points to output/ : this is where dotnet pack / nuget pack outputs go and what gets published as pipeline artifacts
  • Download steps in ci-build-nugets-job.yml are hardcoded to $(Build.SourcesDirectory)/packages instead of using
    $(packagePath), so downloaded dependencies stay in the NuGet local feed directory and don't contaminate the artifact upload

Notes

This PR (Part 2) covers the CI/PR validation pipelines that build packages for testing during pull requests and continuous integration. No MSBuild or .gitignore changes needed, those were handled in Part 1.

@samsharma2700 samsharma2700 requested a review from a team as a code owner March 5, 2026 22:50
Copilot AI review requested due to automatic review settings March 5, 2026 22:50
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Separates downloaded dependency packages from newly-built NuGet outputs in CI/PR pipelines to avoid re-uploading unrelated packages as artifacts.

Changes:

  • Updates packagePath to use output/ as the build/artifact output directory.
  • Redirects pipeline artifact downloads to packages/ (local feed) instead of $(packagePath).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/pipelines/libraries/ci-build-variables.yml Moves packagePath from packages/ to output/ and documents why.
eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml Downloads dependent package artifacts into packages/ to avoid contaminating build outputs/artifacts.

@paulmedynski paulmedynski added this to the 7.0.0 milestone Mar 9, 2026
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Mar 9, 2026
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.09%. Comparing base (3303d80) to head (b9398d5).
⚠️ Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3303d80) and HEAD (b9398d5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3303d80) HEAD (b9398d5)
CI-SqlClient 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4007      +/-   ##
==========================================
- Coverage   74.38%   67.09%   -7.30%     
==========================================
  Files         287      282       -5     
  Lines       43982    67171   +23189     
==========================================
+ Hits        32717    45068   +12351     
- Misses      11265    22103   +10838     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 67.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You should be able to temporarily open a PR against the ADO repo to do a test run of the ci pipeline against these changes.

@samsharma2700
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

4 participants