Closed
Conversation
added 9 commits
February 28, 2017 16:38
.dots ignored bootstrap.sh and used the hard-coded original dev-setup by donnemartin
bootstrap.sh copied all the installation files to the home directory.
Clean up .dots: * Rename .dots to setup.sh. The name ".dots" doesn't describe the script purpose and is not consistent with other installation scripts. * Remove warning message because it is duplicated in dots.sh bootstrap.sh had 2 separate functions and had been split to reflect them: * sync.sh : sync dev-setup repo to the local working directory if repo was cloned to local machine. * dots.sh : sync dots files to home user directory .
Owner
|
Hi @dweawyn, thanks for the PR! I've been tied up lately, hope to review this in the next few weeks. |
josephmilla
approved these changes
Apr 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the ideas from #42 a bit further :
Refactor
.dots:.dotstosetup.sh. The name.dotsdoesn't describe the script's purpose and is not consistent with other installation scripts.dots.shbootstrap.shhad 2 separate functions and has been split to reflect them:update.sh: sync dev-setup repo to the local working directory if repo was cloned to working directory.dots.sh: sync dots files to local home directory .I also updated the README to reflect those changes.