Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/router/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export function parseQuery(query) {

// Simple parse
query.split('&').forEach(param => {
const parts = param.replace(/\+/g, ' ').split('=');
const parts = param.replace(/\+/g, ' ').split(/=(.*)/s);

res[parts[0]] = parts[1] && decode(parts[1]);
});
Expand Down
22 changes: 22 additions & 0 deletions test/unit/router-util.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,33 @@ import {
getClickedLink,
getSidebarNavigationTarget,
isCurrentContextNavigation,
parseQuery,
} from '../../src/core/router/util.js';

// Suite
// -----------------------------------------------------------------------------
describe('router/util', () => {
describe('parseQuery()', () => {
test('preserves equals signs inside query values', () => {
expect(parseQuery('?id=a=b=c&other=ok')).toEqual({
id: 'a=b=c',
other: 'ok',
});
});

test.each([
['?value==', { value: '=' }],
['?value=a%3Db', { value: 'a=b' }],
['?value=a+b=c', { value: 'a b=c' }],
['?empty=&flag', { empty: '', flag: undefined }],
])(
'parses %s without changing empty or encoded values',
(query, expected) => {
expect(parseQuery(query)).toEqual(expected);
},
);
});

describe('navigation click helpers', () => {
test('finds a link from a nested click target', () => {
document.body.innerHTML = '<a href="/guide"><span>Guide</span></a>';
Expand Down