Return error when service update triggers rollback #6756
Closed
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error when service update triggers rollback
When a service update fails and triggers a rollback, the command now
exits with code 1 instead of 0, allowing deployment tools to detect
failures.
Fixes #6752
- What I did
Modified the
ServiceProgressfunction incli/command/service/progress/progress.goto return an error when automatic rollback occurs after a failed update, instead of returning success.- How I did it
Added a check after service convergence verification. When the
rollbackflag is true (indicating the update was rolled back), the function returns an error, causing the CLI to exit with code 1.- How to verify it
docker swarm initexit 0healthcheck)exit 1in the healthcheckdocker stack deploy --detach=false -c docker-compose.yml test-rollbackecho $?- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
🐳