Repository navigation
nats: fix cluster examples for the scratch-based default image - #2711
Open
koksharoff wants to merge 1 commit into
Open
koksharoff wants to merge 1 commit into
koksharoff wants to merge 1 commit into
Conversation
Member
|
cc (fwiw, we usually skip |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2710 / #2491: the variant descriptions are now fixed, but the cluster examples still pass
-c /etc/nats/nats-server.conf, which only exists in the -alpine variant. On the default (scratch) image the second server exits withopen /etc/nats/nats-server.conf: no such file or directory.Changes (only nats/content.md):
--linkwith a user-defined networkTested the updated commands verbatim against the 2.15 image: the second server joins the cluster (routes visible in /routez). markdownfmt reports no changes.
cc @bruth