You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think some wrong solutions (for example my first one) can rely on the 'server' starting before 'clients'. I propose a crutch for this. It can catch some "naive" solutions
You should never expect server is started before clients. Even depends_on doesn't guarantee that. It guarantees the container start order, but you have to add extra steps to verify that server is ready to accept and process requests, and only after that start client containers. Not sure if it's possible to combine depends_on and readiness probes in docker.
The correct way to handle that is to add retries on the client side / or set up "restart always" policy for clients. Clients should gracefully handle temporary server's unavailability.
You should never expect server is started before clients. Even depends_on doesn't guarantee that. It guarantees the container start order, but you have to add extra steps to verify that server is ready to accept and process requests, and only after that start client containers. Not sure if it's possible to combine depends_on and readiness probes in docker.
The correct way to handle that is to add retries on the client side / or set up "restart always" policy for clients. Clients should gracefully handle temporary server's unavailability.
That's the reason of this pr... it makes the server container start AFTER clients, so it will catch some wrong solutions
nook0110
changed the title
Add depend_on in docker compose
Add depends_on in docker compose
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think some wrong solutions (for example my first one) can rely on the 'server' starting before 'clients'. I propose a crutch for this. It can catch some "naive" solutions