Draft
Conversation
Danbr4d
added
Type: Enhancement
Contributor
Author
|
Still needs the storing of the error and convert to forces added in |
Danbr4d
force-pushed
the
SANS-driven-MD
branch
from
4a7b38a to
c3199f6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: b6d4461 | Previous: 4806267 | Ratio |
|---|---|---|---|
BM_Box_MinimumImage<CubicBox> |
13.051797185081941 ns/iter |
5.59962884890997 ns/iter |
2.33 |
BM_HistogramBinning_1d/16777216 |
23.843958531753838 ns/iter |
9.994435588861185 ns/iter |
2.39 |
BM_HistogramBinning_2d/16777216 |
52.332842716055595 ns/iter |
19.895944641912394 ns/iter |
2.63 |
BM_HistogramBinning_3d/16777216 |
62.2130550436942 ns/iter |
28.426725104892064 ns/iter |
2.19 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new way of processing and driving SANS data has been detailed
https://biophys.uni-saarland.de/storage/publication/Chatzimagas_MethodsEnzymol_2023.pdf
This is a test module to see how to apply this in Dissolve.