Add support for external_id in topic creation

[thomasrossetto]

Hi,
According to the Discourse docs, I have added external_id to the list of supported options for topic creation.

[thomasrossetto]

Ops, I forgot to assign reviewers :( @oblakeerickson

[blake-discourse]

@thomasrossetto awesome thank you!

Looks like there is a small linting error.

Not sure if you have stree locally, but you can run stree write lib/discourse_api/api/topics.rb and it will fix it.

If not the diff looks like this

diff --git a/lib/discourse_api/api/topics.rb b/lib/discourse_api/api/topics.rb
index a92c398..944deb3 100644
--- a/lib/discourse_api/api/topics.rb
+++ b/lib/discourse_api/api/topics.rb
@@ -11,7 +11,15 @@ module DiscourseApi
           API
             .params(args)
             .required(:title, :raw)
-            .optional(:skip_validations, :category, :auto_track, :created_at, :api_username, :tags, :external_id)
+            .optional(
+              :skip_validations,
+              :category,
+              :auto_track,
+              :created_at,
+              :api_username,
+              :tags,
+              :external_id,
+            )
         post("/posts", args.to_h)
       end

And could you add a test? I think it can look similar to this tags one:

  describe "#create_topic_with_tags" do
    before do
      stub_post("#{host}/posts").to_return(
        body: fixture("create_topic_with_tags.json"),
        headers: {
          content_type: "application/json",
        },
      )
    end

    it "makes the post request" do
      client.create_topic title: "Sample Topic Title",
                          raw: "Sample topic content body",
                          tags: %w[asdf fdsa]
      expect(a_post("#{host}/posts")).to have_been_made
    end

    it "returns success" do
      response =
        client.create_topic title: "Sample Topic Title",
                            raw: "Sample topic content body",
                            tags: %w[asdf fdsa]
      expect(response).to be_a Hash
      expect(response["topic_id"]).to eq 21
    end
  end

So you might need to make a new fixture, and then in your expect check for the external_id in your response (I'm pretty sure its returned).

[blake-discourse]

@thomasrossetto just checking in if you need any help? Would love to get this in. There are just some small updates we need to make.

[thomasrossetto]

Sorry @blake-discourse! I’ll try to get this done in the next few days 😉

[thomasrossetto]

I decided to take a quick look just now. Formatting looks fine now.

About testing: if you provide an external ID, it doesn’t appear in the response. But I’ve implemented this API
to resolve the correct URL. You can find the logic in my last commit.

I can add a test for it if you think it’s necessary.

[blake-discourse]

Looks great, thank you!

[blake-discourse]

@thomasrossetto there is a new gem version now with your change https://rubygems.org/gems/discourse_api/versions/2.1.0 :)