Repository navigation
fix(build): separate preprocessor definitions - #212
Open
kellen-miller wants to merge 1 commit into
Open
kellen-miller wants to merge 1 commit into
kellen-miller wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GYP concatenates adjacent
"POSIX," "__STDC_FORMAT_MACROS"literals into one malformed compiler definition. Separate the entries so both macros are defined correctly. Closes #210.Summary
Evidence
-DPOSIX,__STDC_FORMAT_MACROSemits an invalid macro-name warning and leaves__STDC_FORMAT_MACROSundefined.After: Separate
-DPOSIX -D__STDC_FORMAT_MACROSdefines both macros to 1 without that warning.node-pre-gyp rebuild --napi_build_version=3) andnpm testpass.git diff --checkpasses. Repository-widenpm run lintstops on existing formatting in unchangedtests/test.js; this PR only changesbinding.gyp.Merge Danger
Door: two-way
Blast Radius: build
No codec source, compiler warning settings, or runtime JavaScript changes.